Small change - #446
Conversation
| std::format_to(iter, " FactionFiles demo delete after send: {}\n", cfg.fflink_demo_delete_after_send); | ||
| std::format_to(iter, " Auto-record demos: {}\n", cfg.demo_auto_record); | ||
| if (cfg.demo_auto_record) { | ||
| std::format_to(iter, " Include chat: {}\n", cfg.demo_chat_record); |
There was a problem hiding this comment.
This applies to manual recordings too, should not be nested. The other nestings look right.
| @@ -1,4 +1,4 @@ | |||
| file(GLOB EXPERIMENTAL_SRCS experimental/*.cpp experimental/*.h) | |||
| file(GLOB_RECURSE EXPERIMENTAL_SRCS experimental/*.cpp experimental/*.h) | |||
There was a problem hiding this comment.
It allows code in sub-directories so it is useful. I have used it before but I do not use it at the moment. It is easier for me to have it upstream.
| output(s.c_str(), nullptr); | ||
| } | ||
|
|
||
| template <typename... Args> |
There was a problem hiding this comment.
Is this intended for future use? doesnt seem to be used currently?
There was a problem hiding this comment.
I think it might be useful or I may use it later in a PR. I already do use it internally.
| if (key & rf::KEY_CTRLED) { | ||
| key_state[VK_CONTROL] = 0x80; | ||
| } | ||
| // HACKFIX. Must be set for `ToUnicode` to produce capitalized letters. |
There was a problem hiding this comment.
Is this actually a hackfix? Seems no? Isn't this the proper way to do this?
There was a problem hiding this comment.
It is a hackfix due to subtle timing issues. The key has been captured at an earlier time. But it is good enough imo.
| std::format_to(iter, " Demos:\n"); | ||
| std::format_to(iter, " Auto-record: {}\n", cfg.demo_auto_record); | ||
| std::format_to(iter, " Include chat: {}\n", cfg.demo_chat_record); | ||
| std::format_to(iter, " Upload to FactionFiles: {}\n", cfg.fflink_demo_upload); |
There was a problem hiding this comment.
Only auto recorded demos ever get uploaded to FF, perhaps it would make sense to order them this way:
Demos:
- Include chat
- Auto-record
- Upload to FF
- Max size,etc.
2 participants
No description provided.